Re: clang's static checker report. - Mailing list pgsql-hackers

From Grzegorz Jaskiewicz
Subject Re: clang's static checker report.
Date
Msg-id 19454D21-D033-4F9B-8EE5-62F6729F6348@pointblue.com.pl
Whole thread Raw
In response to Re: clang's static checker report.  (Greg Stark <gsstark@mit.edu>)
Responses Re: clang's static checker report.  (Greg Stark <gsstark@mit.edu>)
List pgsql-hackers
On 29 Aug 2009, at 17:35, Greg Stark wrote:

> We still have things like this showing "division by zero":
>
> Assert(activeTapes > 0);
> 1913        slotsPerTape = (state->memtupsize - state->mergefirstfree) /  
> activeTapes;
>
>
> It looks like if you marked ExceptionalCondition() as never returning
> then it should hide this.
well, it is marked as such , here's excerpt from differences to head:
 extern int ExceptionalCondition(const char *conditionName,                                         const char
*errorType,
-                                        const char *fileName, int  
lineNumber);
+                                        const char *fileName, int  
lineNumber) __attribute__((analyzer_noreturn));





pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: clang's static checker report.
Next
From: Greg Stark
Date:
Subject: Re: clang's static checker report.