Re: We need to log aborted autovacuums - Mailing list pgsql-hackers

From Tom Lane
Subject Re: We need to log aborted autovacuums
Date
Msg-id 19414.1295293593@sss.pgh.pa.us
Whole thread Raw
In response to Re: We need to log aborted autovacuums  (Josh Berkus <josh@agliodbs.com>)
Responses Re: We need to log aborted autovacuums  (Simon Riggs <simon@2ndQuadrant.com>)
Re: We need to log aborted autovacuums  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
Josh Berkus <josh@agliodbs.com> writes:
> However, we'd want a separate lock timeout for autovac, of course.  I'm
> not at all keen on a *statement* timeout on autovacuum; as long as
> autovacuum is doing work, I don't want to cancel it.  Also, WTF would we
> set it to?

Yeah --- in the presence of vacuum cost delay, in particular, a
statement timeout seems about useless for AV.

> Going the statement timeout route seems like a way to create a LOT of
> extra work, troubleshooting, getting it wrong, and releasing patch
> updates.  Please let's just create a lock timeout.

Do we actually need a lock timeout either?  The patch that was being
discussed just involved failing if you couldn't get it immediately.
I suspect that's sufficient for AV.  At least, nobody's made a
compelling argument why we need to expend a very substantially larger
amount of work to do something different.
        regards, tom lane


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.
Next
From: Peter Eisentraut
Date:
Subject: Re: pl/python refactoring