Re: Lots of incorrect comments in nodeFuncs.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Lots of incorrect comments in nodeFuncs.c
Date
Msg-id 1939597.1617927448@sss.pgh.pa.us
Whole thread Raw
In response to Re: Lots of incorrect comments in nodeFuncs.c  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Lots of incorrect comments in nodeFuncs.c  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> hmm ok.  I imagine there must be a better way to say that then since
> it confused at least 1 reader so far.  My problem is that I assumed
> "result" meant the result of the function that the comment is written
> in, not the result of evaluating the given expression during
> execution. If that was more clear then I'd not have been misled.

Maybe like

                case T_ScalarArrayOpExpr:
                    /* ScalarArrayOpExpr's result is boolean ... */
                    coll = InvalidOid;      /* ... so it has no collation */
                    break;

?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Lee
Date:
Subject: Postgresql 13 supported on Solaris 11 O/S on SPARC hardware?
Next
From: Michael Paquier
Date:
Subject: Re: Simplify backend terminate and wait logic in postgres_fdw test