KaiGai Kohei <kaigai@ak.jp.nec.com> writes:
> Tom Lane wrote:
>> Yeah, I remember those. What needs to be looked at here is *why* the
>> output is changing. For a patch that allegedly does not touch the
>> planner, it's fairly disturbing that you don't get the same results.
> SE-PostgreSQL does not touch the planner, but it modifies given query
> to filter violated tuples for the current user.
Hmm. Is that really a good idea, compared to hard-wiring the checks
into nodeSeqscan and friends? I didn't look at the query-rewriting
portion of the patch in any detail, but I'd tend not to trust such
a technique very far: getting it right is going to be quite complex
and probably bug prone.
>> Are you sure that the security_label type should not have an array type?
> Yes, security_label type should not have an array type.
You didn't provide one ounce of justification for making it not obey the
expected behavior, so I'm not accepting this position. It doesn't seem
to me to be all that unlikely that users would want to compute with
arrays of security labels. As an example:select ... where security_label in ('foo', 'bar')
which will become an = ANY(ARRAY[]) construct under the hood.
regards, tom lane
