Re: Dubious coding in nbtinsert.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Dubious coding in nbtinsert.c
Date
Msg-id 1927570.1617915479@sss.pgh.pa.us
Whole thread Raw
In response to Re: Dubious coding in nbtinsert.c  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> You had a near-identical complaint about a compiler warning that led
> to my commit d64f1cdf2f4 -- that one involved _bt_check_unique()'s
> curitup, while this one is about curitemid. While I have no problem
> silencing this compiler warning now, I don't see any reason to not
> just do the same thing again. Which is to initialize the pointer to
> NULL.

Works for me; if there is any bug in the logic, we'll get a core dump
and can investigate.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: pgsql: autovacuum: handle analyze for partitioned tables
Next
From: Mark Dilger
Date:
Subject: Re: pg_amcheck contrib application