Re: [PATCHES] Custom variable class segmentation fault - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Custom variable class segmentation fault
Date
Msg-id 19268.1155669739@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Custom variable class segmentation fault  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [PATCHES] Custom variable class segmentation fault  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> I merely said that the way the patch was presented, with significant 
> code refactoring mixed in, I couldn't review it (as effectively as 
> perhaps otherwise).  FWIW, I believe that the general approach is 
> sound, but I haven't actually "reviewed" the patch completely.

Given the multiple problems already found, I feel quite uncomfortable
with putting it back in until another set of eyeballs has been over
it.  Do you have time to do a full review anytime soon?  I'm trying
to deal with all the other stuff in the queue, and so would prefer
not to spend my own time on it ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] PL instrumentation plugin and Rendezvous variable support - version 2
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Forcing current WAL file to be archived