Re: [PATCHES] Custom variable class segmentation fault - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCHES] Custom variable class segmentation fault
Date
Msg-id 200608151830.33645.peter_e@gmx.net
Whole thread Raw
In response to Re: [PATCHES] Custom variable class segmentation fault  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCHES] Custom variable class segmentation fault
List pgsql-hackers
Andrew Dunstan wrote:
> If you and Peter have reviewed it thoroughly then I see no reason the
> patch should not be applied.

I merely said that the way the patch was presented, with significant 
code refactoring mixed in, I couldn't review it (as effectively as 
perhaps otherwise).  FWIW, I believe that the general approach is 
sound, but I haven't actually "reviewed" the patch completely.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/


pgsql-hackers by date:

Previous
From: "Jaime Casanova"
Date:
Subject: insert/update/delete returning and rules
Next
From: AgentM
Date:
Subject: Re: An Idea for planner hints