Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead - Mailing list pgsql-hackers

From Nikolay Shaplov
Subject Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead
Date
Msg-id 1921952.xWjPjWaBPZ@x200m
Whole thread Raw
In response to Re: [PATCH] get rid of StdRdOptions, use individual binaryreloptions representation for each relation kind instead  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses RE: [PATCH] get rid of StdRdOptions, use individual binaryreloptions representation for each relation kind instead  ("Iwata, Aya" <iwata.aya@jp.fujitsu.com>)
List pgsql-hackers
Tree view 
В письме от четверг, 17 января 2019 г. 20:33:06 MSK пользователь Alvaro
Herrera написал:

> You introduced new macros IsHeapRelation and IsViewRelation, but I don't
> want to introduce such API.  Such things have been heavily contested and
> I don't to have one more thing to worry about for this patch, so please
> just put the relkind directly in the code.
Sorry.
I've been trying to avoid repeating

   (AssertMacro(relation->rd_rel->relkind == RELKIND_RELATION ||       \
                relation->rd_rel->relkind == RELKIND_MATVIEW),         \
all the time.

Fixed.

Also I make more relaxed parallel_workers behavior in get_relation_info as we
discussed in another thread.
Attachment

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
Next
From: Fabien COELHO
Date:
Subject: Re: Alternative to \copy in psql modelled after \g