Re: [BUGS] BUG #2846: inconsistent and confusing handling of - Mailing list pgsql-patches

From Tom Lane
Subject Re: [BUGS] BUG #2846: inconsistent and confusing handling of
Date
Msg-id 19208.1167246902@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #2846: inconsistent and confusing handling of  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [BUGS] BUG #2846: inconsistent and confusing  (Bruce Momjian <bruce@momjian.us>)
Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing handling  (Roman Kononov <kononov195-pgsql@yahoo.com>)
List pgsql-patches
Bruce Momjian <bruce@momjian.us> writes:
> I have made some more progress on this patch.

I'm not convinced that you're fixing things so much as doing your best
to destroy IEEE-compliant float arithmetic behavior.

I think what we should probably consider is removing CheckFloat4Val
and CheckFloat8Val altogether, and just letting the float arithmetic
have its head.  Most modern hardware gets float arithmetic right per
spec, and we shouldn't be second-guessing it.

A slightly less radical proposal is to reject only the case where
isinf(result) and neither input isinf(); and perhaps likewise with
respect to NaNs.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [BUGS] BUG #2846: inconsistent and confusing handling of
Next
From: Dhanaraj M
Date:
Subject: Allow the identifier length to be increased via a configure option