Re: JSON constructors and window functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: JSON constructors and window functions
Date
Msg-id 1904842.1649087011@sss.pgh.pa.us
Whole thread Raw
In response to Re: JSON constructors and window functions  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: JSON constructors and window functions  (Greg Stark <stark@mit.edu>)
Re: JSON constructors and window functions  (Andrew Dunstan <andrew@dunslane.net>)
Re: JSON constructors and window functions  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 4/3/22 22:46, Andrew Dunstan wrote:
>> On 4/3/22 20:11, Andres Freund wrote:
>>> I don't think you're allowed to free stuff in a finalfunc - we might reuse the
>>> transition state for further calls to the aggregate.

>> Doh! Of course! I'll fix it in the morning. Thanks.

> I've committed a fix for this. I didn't find something to clean out the
> hash table, so I just removed the 'hash_destroy' and left it at that.
> All the test I did came back with expected results.
> Maybe a hash_reset() is something worth having assuming it's possible? I
> note that simplehash has a reset function.

But removing the hash entries would be just as much of a problem
wouldn't it?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Next
From: Dilip Kumar
Date:
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)