Re: sslinfo extension - add notbefore and notafter timestamps - Mailing list pgsql-hackers

From Cary Huang
Subject Re: sslinfo extension - add notbefore and notafter timestamps
Date
Msg-id 18e53530897.10365d92d1050957.2899800306134133143@highgo.ca
Whole thread Raw
In response to Re: sslinfo extension - add notbefore and notafter timestamps  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: sslinfo extension - add notbefore and notafter timestamps
List pgsql-hackers
Hi Jacob

> Hi Cary, did you have any thoughts on the timestamptz notes from my last mail?
> 
> > It might also be nice to rename
> > ASN1_TIME_to_timestamp().
> >
> > Squinting further at the server backend implementation, should that
> > also be using TimestampTz throughout, instead of Timestamp? It all
> > goes through float8_timestamptz at the end, so I guess it shouldn't
> > have a material impact, but it's a bit confusing.

Sorry I kind of missed this review comment from your last email. Thanks for bringing it up again though. I think it is
rightto change the backend references of "timestamp" to "timestampTz" for consistency reasons. I have gone ahead to
makethe changes.
 

I have also reviewed the wording on the documentation and removed "UTC" from the descriptions. Since sslinfo extension
andpg_stat_ssl both return timestampTz in whatever timezone PostgreSQL is running on, they do not always return UTC
timestamps.

Attached is the v10 patch with the above changes. Thanks again for the review.

Best regards

Cary Huang
-------------
HighGo Software Inc. (Canada)
cary.huang@highgo.ca
www.highgo.ca

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: REVOKE FROM warning on grantor
Next
From: Robert Haas
Date:
Subject: Re: Possibility to disable `ALTER SYSTEM`