Re: drop tablespace failed when location contains .. on win32 - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: drop tablespace failed when location contains .. on win32
Date
Msg-id 18bc9d6b-4c9d-771f-b7d9-f294f3b34d2e@dunslane.net
Whole thread Raw
In response to Re: drop tablespace failed when location contains .. on win32  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: drop tablespace failed when location contains .. on win32
List pgsql-hackers
On 1/30/22 16:50, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> In order to make the tests cheap, there is no need to have a separate
>> module in src/test/modules/ as your patch 0002 is doing.  Instead, you
>> should move the C code of your SQL function test_canonicalize_path()
>> to src/test/regress/regress.c, then add some tests in
>> src/test/regress/sql/, with a SQL function created in the test script
>> that feeds from what would be added to regress.so.
> Here's a revised patch version that does it like that.  I also
> reviewed and simplified the canonicalize_path logic.  I think
> this is committable.


LGTM


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: CREATEROLE and role ownership hierarchies
Next
From: Mark Dilger
Date:
Subject: Re: CREATEROLE and role ownership hierarchies