Re: [GENERAL] Insert result does not match record count - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [GENERAL] Insert result does not match record count
Date
Msg-id 1892.1374688103@sss.pgh.pa.us
Whole thread Raw
In response to Re: [GENERAL] Insert result does not match record count  (Vik Fearing <vik.fearing@dalibo.com>)
Responses Re: [GENERAL] Insert result does not match record count
List pgsql-hackers
Vik Fearing <vik.fearing@dalibo.com> writes:
> Also worth mentioning is bug #7766.
> http://www.postgresql.org/message-id/E1Tlli5-0007tR-HO@wrigleys.postgresql.org

Yeah, did you read that whole thread?  The real issue here is going to
be whether client-side code falls over on wider-than-32-bit counts.
We can fix the backend and be pretty sure that we've found all the
relevant places inside it, but we'll just be exporting the issue.

I did look at libpq and noted that it doesn't seem to have any internal
problem, because it returns the count to callers as a string (!).
But what do you think are the odds that callers are using code that
won't overflow?  I'd bet on finding atoi() or suchlike in a lot of
callers.  Even if they thought to use strtoul(), unsigned long is
not necessarily 64 bits wide.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Review: UNNEST (and other functions) WITH ORDINALITY
Next
From: Karol Trzcionka
Date:
Subject: Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements