Re: alter subscription drop publication fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: alter subscription drop publication fixes
Date
Msg-id 1885279.1621005978@sss.pgh.pa.us
Whole thread Raw
In response to Re: alter subscription drop publication fixes  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: alter subscription drop publication fixes
List pgsql-hackers
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
> On Fri, May 14, 2021 at 7:58 PM vignesh C <vignesh21@gmail.com> wrote:
>> I have changed it to:
>> <literal>ADD</literal> adds additional publications,
>> -      <literal>DROP</literal> removes publications from the list of
>> +      <literal>DROP</literal> removes publications to/from the list of

> How about "Publications are added to or dropped from the existing list
> of publications by <literal>ADD</literal>  or <literal>DROP</literal>
> respectively." ?

We generally prefer to use the active voice, so I don't think
restructuring the sentence that way is an improvement.  The quoted
bit would be better left alone entirely.  Or maybe split it into
two sentences, but keep the active voice.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: allow specifying direct role membership in pg_hba.conf
Next
From: Chapman Flack
Date:
Subject: Re: allow specifying direct role membership in pg_hba.conf