Julien Rouhaud <rjuju123@gmail.com> writes:
> It turns out that in hypopg I totally missed that
> explain_get_index_name_hook should take care of quoting the indexname.
> People only want to know whether the hypothetical index is used or
> not, so the lack of correct quoting didn't prevent that (the
> hypothetical index name is automatically generated and includes its
> oid). The patch looks good to me, and +1 for backpatch!
Ah, I'd wondered whether there might be hook users that "should" be
doing quoting and were not. So the impact on hypopg would be:
1. Non-text EXPLAIN formats are already properly quoted, and will
remain so.
2. Text-format EXPLAIN output will grow double-quotes around the
hypothetical index names, which are not there at present (I believe,
but didn't test it). This shouldn't bother human users particularly,
but conceivably it might break hypopg's regression tests?
According to codesearch.debian.net and a Google search, hypopg is the
only active external user of explain_get_index_name_hook. (I should
have thought to do that search yesterday, but did not.)
regards, tom lane
