Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64
Date
Msg-id 18779.1303968115@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64  (Dave Page <dpage@postgresql.org>)
List pgsql-committers
Tree view 
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Tom Lane's message of mié abr 27 17:10:37 -0300 2011:
>> Alvaro Herrera <alvherre@commandprompt.com> writes:
>>> Apparently this change is causing Moa's SunStudio compiler to fail an
>>> assertion.

>> [ scratches head... ]  Hard to see why, there's nothing at all
>> interesting in that code.

> I agree, but it fails exactly in that code, and started to fail
> immediately after that patch.

> Maybe casting the 2 to int64 would fix it?

I'm not excited about trying random code changes to dodge a compiler bug
with a 24-hour turnaround time.  Dave, can you poke at this?

            regards, tom lane

pgsql-committers by date:

Previous
From: h-saito@pgfoundry.org (Hiroshi Saito)
Date:
Subject: psqlodbc - psqlodbc: Prep release 09.00.0300.
Next
From: dpage@pgfoundry.org (Dave Page)
Date:
Subject: edb-debugger - server: Support the new DefineCustomStringVariable API in