Re: Initial refactoring of plperl.c - draft [PATCH] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Initial refactoring of plperl.c - draft [PATCH]
Date
Msg-id 18765.1259081826@sss.pgh.pa.us
Whole thread Raw
In response to Initial refactoring of plperl.c - draft [PATCH]  (Tim Bunce <Tim.Bunce@pobox.com>)
Responses Re: Initial refactoring of plperl.c - draft [PATCH]
List pgsql-hackers
Tim Bunce <Tim.Bunce@pobox.com> writes:
> The next step I plan is to move the large multi-line string literal
> macros (PERLBOOT, SAFE_OK etc) into external perl code files.
> That'll make refactoring, extending and maintaining that perl
> code far simpler.

That does not seem like it accomplishes anything from the user's
perspective except to add more points of failure.  To name just one:
would you like to debug a problem that stems from a version mismatch
between plperl.so and the external perl files?  I wouldn't.

I can see wanting the *source* to be separate files, but having it as a
compiled constant string in the executable seems like the right thing.

Since this language is obviously going to require Perl to be present at
compile time, running a little Perl script to convert the source into a
C literal wouldn't be a problem AFAICS.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tim Bunce
Date:
Subject: Initial refactoring of plperl.c - draft [PATCH]
Next
From: Hitoshi Harada
Date:
Subject: Syntax conflicts in frame clause