Re: WIP: splitting BLCKSZ - Mailing list pgsql-patches

From Tom Lane
Subject Re: WIP: splitting BLCKSZ
Date
Msg-id 18709.1143055188@sss.pgh.pa.us
Whole thread Raw
In response to WIP: splitting BLCKSZ  (Mark Wong <markw@osdl.org>)
Responses Re: WIP: splitting BLCKSZ  (Mark Wong <markw@osdl.org>)
List pgsql-patches
Mark Wong <markw@osdl.org> writes:
> I proposed to explore splitting BLCKSZ into separate values for logging
> and data to see if there might be anything to gain:
>     http://archives.postgresql.org/pgsql-hackers/2006-03/msg00745.php
> My first pass was to do more or less a search and replace (attached) and
> I am already running into trouble with a 'make check' (below).  I'm
> guessing that when initdb is run, I'm not properly saving the values
> that I've defined for DATA_BLCKSZ and possibly LOG_BLCKSZ.

I'd suggest leaving BLCKSZ as-is and inventing XLOG_BLCKSZ to be used
only within the WAL code; should make for a *far* smaller patch.
Offhand I don't think that anything except xlog.c knows the WAL block
size --- it should be fairly closely associated with dependencies on
XLOG_SEG_SIZE, if you are looking for something to grep for.

            regards, tom lane

pgsql-patches by date:

Previous
From: Mark Wong
Date:
Subject: WIP: splitting BLCKSZ
Next
From: Qingqing Zhou
Date:
Subject: rm_desc patch