Re: Ensuring hash tuples are properly maxaligned - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Ensuring hash tuples are properly maxaligned
Date
Msg-id 18676.1514944157@sss.pgh.pa.us
Whole thread Raw
In response to Re: Ensuring hash tuples are properly maxaligned  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-01-02 20:40:50 -0500, Tom Lane wrote:
>> OK, then there's not a live bug, but I'm a bit tempted to get rid of
>> the data[] member anyway.  It's not clear to me now that keeping it
>> results in net cleaner code.  Thoughts?

> I like that plan. I don't think the data field buys us anything, and I
> personally in most cases find "fully manual" alignment code easier to
> reason about than fiddling with padding fields.

Agreed --- I'll go do that.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Ensuring hash tuples are properly maxaligned
Next
From: Noah Misch
Date:
Subject: Re: Contributing with code