Re: pgsql/src/bin/pg_dump pg_dumpall.sh - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src/bin/pg_dump pg_dumpall.sh
Date
Msg-id 18557.1018558560@sss.pgh.pa.us
Whole thread Raw
In response to pgsql/src/bin/pg_dump pg_dumpall.sh  (momjian@postgresql.org (Bruce Momjian - CVS))
Responses Re: pgsql/src/bin/pg_dump pg_dumpall.sh
List pgsql-committers
momjian@postgresql.org (Bruce Momjian - CVS) writes:
> Modified files:
>     src/bin/pg_dump: pg_dumpall.sh

> Log message:
>     Fix pg_upgrade to handle dbnames, user/group names with spaces.

I think it's illusory to imagine that this fixes the issue.  Unless
"read"'s behavior is more tightly specified than I think, you are still
gonna have trouble with leading, trailing, or consecutive blanks.

I'm also concerned that you've opened up portability issues concerning
newlines embedded in shell literals (eg, does that sed command portably
do what you think?).

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql/ oc/src/sgml/catalogs.sgml oc/src/sgml/r ...
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql/src/bin/pg_dump pg_dumpall.sh