Re: Win32 defines - Mailing list pgsql-patches

From Tom Lane
Subject Re: Win32 defines
Date
Msg-id 18367.1050506804@sss.pgh.pa.us
Whole thread Raw
In response to Re: Win32 defines  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Win32 defines  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Win32 defines  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> Why is this removing the use of the TIMEZONE_GLOBAL macro?

> It was Peter's suggestion.  Once we had a port-specific define, we
> should use timezone directly, no?

> #define timezone _timezone

Oh, I missed that part.  A bit risky IMHO --- the macro might expand in
places you didn't expect/want.  TIMEZONE_GLOBAL is unlikely to cause
any such conflict ...

            regards, tom lane


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Win32 defines
Next
From: Sean Chittenden
Date:
Subject: Re: [HACKERS] Are we losing momentum?