Re: BUG #5234: ALTER TABLE ... RENAME COLUMN change view definition incorrectly - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #5234: ALTER TABLE ... RENAME COLUMN change view definition incorrectly
Date
Msg-id 18262.1260427565@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #5234: ALTER TABLE ... RENAME COLUMN change view definition incorrectly  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: BUG #5234: ALTER TABLE ... RENAME COLUMN change view definition incorrectly  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-bugs
Robert Haas <robertmhaas@gmail.com> writes:
> I'm not an expert on this area of the code, but can we just ignore
> isNatural and usingClause when deparsing?

No.  These properties are *not* ignorable because doing so changes the
set of returned columns --- you should get only one column out not two.

My reading of the spec is that USING (and therefore NATURAL) is defined
to join identically named columns.  Therefore, renaming one of the input
columns as the OP did *should* indeed *must* break the view.  The problem
is not how to make it work, it's how to give an error message that
doesn't look like an internal failure.

(This wasn't one of the SQL committee's better ideas IMO, but ours not
to reason why.)

            regards, tom lane

pgsql-bugs by date:

Previous
From: Robert Haas
Date:
Subject: Re: BUG #5234: ALTER TABLE ... RENAME COLUMN change view definition incorrectly
Next
From: Heikki Linnakangas
Date:
Subject: Re: getting libpqd.lib and libpqd.dll for postgesql 8.4.1 on Vista with VS8 or cygwin g++