Re: Is this a bug in pg_current_logfile() on Windows? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Is this a bug in pg_current_logfile() on Windows?
Date
Msg-id 1819939.1594308283@sss.pgh.pa.us
Whole thread Raw
In response to Re: Is this a bug in pg_current_logfile() on Windows?  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: Is this a bug in pg_current_logfile() on Windows?
List pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 7/9/20 11:04 AM, Tom Lane wrote:
>> Therefore, we either should figure out how to get msys perl to do
>> that conversion (and remove it from our code altogether), or make the
>> conversions conditional on "is it msys perl?".  I am not quite sure
>> if the existing tests "if $Config{osname} eq 'msys'" are a legitimate
>> implementation of that condition or not --- it seems like nominally
>> they are checking the OS not the Perl, but maybe it's close enough.

> If the reported OS is msys (it's a pseudo OS in effect) then the perl
> must be msys' perl. Even when called from msys, native perl reports the
> OS as MSWin32. So yes, close enough.

Cool, I'll go try changing all those conditions to use the msys test.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Is this a bug in pg_current_logfile() on Windows?
Next
From: Stephen Frost
Date:
Subject: Re: Postgres is not able to handle more than 4k tables!?