Postgres Pro
Downloads
Home   >   mailing lists

Re: JUMBLE_SIZE macro in two files - Mailing list pgsql-hackers

From Tom Lane
Subject Re: JUMBLE_SIZE macro in two files
Date
Msg-id 1817528.1664889404@sss.pgh.pa.us
Whole thread Raw
In response to JUMBLE_SIZE macro in two files  (bt22nakamorit <bt22nakamorit@oss.nttdata.com>)
Responses Re: JUMBLE_SIZE macro in two files  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
bt22nakamorit <bt22nakamorit@oss.nttdata.com> writes:
> queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024.
> Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition 
> in queryjumble.c should be deleted.

I would go more for taking it out of queryjumble.h.  I see no
reason why that constant needs to be world-visible.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [patch] \g with multiple result sets and \watch with copy queries
Next
From: Tom Lane
Date:
Subject: Re: get rid of Abs()