Re: curious regression failures - Mailing list pgsql-hackers

From Tom Lane
Subject Re: curious regression failures
Date
Msg-id 18147.1190338010@sss.pgh.pa.us
Whole thread Raw
In response to Re: curious regression failures  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: curious regression failures
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> In any case, at that point we are mostly done with the expensive steps
> of vacuuming, so the transaction finishes not long after this.  I don't
> think this issue is worth inventing a new invalidation mechanism.

Yeah, I agree --- there are only a few catalog updates left to do after
we truncate.  If we held the main-table exclusive lock while vacuuming
the TOAST table, we'd have a problem, but it looks to me like we don't.

Idle thought here: did anything get done with the idea of decoupling
main-table vacuum decisions from toast-table vacuum decisions?  vacuum.c
comments
    * Get a session-level lock too. This will protect our access to the    * relation across multiple transactions, so
thatwe can vacuum the    * relation's TOAST table (if any) secure in the knowledge that no one is    * deleting the
parentrelation.
 

and it suddenly occurs to me that we'd need some other way to deal with
that scenario if autovac tries to vacuum toast tables independently.

Also, did you see the thread complaining that autovacuums block CREATE
INDEX?  This seems true given the current locking definitions, and it's
a bit annoying.  Is it worth inventing a new table lock type just for
vacuum?
        regards, tom lane


pgsql-hackers by date:

Previous
From: ஆமாச்சு
Date:
Subject: Beginning Tamil Community for Postgre
Next
From: Tom Lane
Date:
Subject: Re: HOT is applied