Re: _USE_32BIT_TIME_T Patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: _USE_32BIT_TIME_T Patch
Date
Msg-id 17886.1346441794@sss.pgh.pa.us
Whole thread Raw
In response to Re: _USE_32BIT_TIME_T Patch  (Dave Page <dpage@pgadmin.org>)
Responses Re: _USE_32BIT_TIME_T Patch
List pgsql-hackers
Dave Page <dpage@pgadmin.org> writes:
> As a side note - I'm not sure why _USE_32BIT_TIME_T was removed in the
> first place; it was added specifically to avoid this sort of problem,
> though iirc at the time we were thinking of extensions like Slony and
> PostGIS being built with Mingw for use with the VC++ built server.

We removed it when we changed our internal time_t usage to 64 bits:
http://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=cd004067742ee16ee63e55abfb4acbd5f09fbaab
Possibly that was just a brain fade caused by failing to think about
the distinction between pg_time_t and system time_t.  However, the
code has been like that since 8.4, and nobody complained before.
I share Andrew's unease about whether this issue is fully understood.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: patch: shared session variables
Next
From: Robert Haas
Date:
Subject: Re: fairly useless psql compatibility warning?