Re: Fairly serious bug induced by latest guc enum changes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fairly serious bug induced by latest guc enum changes
Date
Msg-id 17856.1214939241@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fairly serious bug induced by latest guc enum changes  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Fairly serious bug induced by latest guc enum changes  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Or are you talking about changing the variable "fsync"? If so, doesn't
> "fsync=off" also change the behavior of other parts of the code, so it's
> not just WAL, which means it'd be pretty unsafe *anyway* unless you
> actually "sync" the disks, and not just fsync?

No, because the other uses of it are controlling whether to issue
fsync() calls dynamically.  The use in get_sync_bit is the only one
that sets persistent state.  In fact md.c goes out of its way to ensure
that changing fsync on the fly behaves as expected.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: Access to localized_str_tolower()
Next
From: Magnus Hagander
Date:
Subject: Re: Fairly serious bug induced by latest guc enum changes