Postgres Pro
Downloads
Home   >   mailing lists

Re: Making empty Bitmapsets always be NULL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Making empty Bitmapsets always be NULL
Date
Msg-id 1785055.1677716790@sss.pgh.pa.us
Whole thread Raw
In response to Re: Making empty Bitmapsets always be NULL  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view 
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Wed, Mar 01, 2023 at 05:59:45PM -0500, Tom Lane wrote:
>> +     /* attidx is zero-based, attrnum is the normal attribute number */
>> +     int         attrnum = attidx + FirstLowInvalidHeapAttributeNumber;

> nitpick: Shouldn't this be an AttrNumber?

I stuck with the existing type choices for those variables,
but I don't mind changing to AttrNumber here.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Making empty Bitmapsets always be NULL
Next
From: Tomas Vondra
Date:
Subject: Re: Memory leak from ExecutorState context?