Re: Poorly thought out code in vacuum - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Poorly thought out code in vacuum
Date
Msg-id 17742.1325871284@sss.pgh.pa.us
Whole thread Raw
In response to Re: Poorly thought out code in vacuum  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Poorly thought out code in vacuum  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Jan 6, 2012 at 12:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> So at this point I've got serious doubts as to the quality of testing of
>> that whole patch, not just this part.

> I tested the case where we skip a block during the first pass, but I
> admit that I punted on testing the case where we skip a block during
> the second pass, because I couldn't think of a good way to exercise
> it.  Any suggestions?

Hack ConditionalLockBufferForCleanup to have a 50% probability of
failure regardless of anything else, for instance via
static int ctr = 0;
if ((++ctr) % 2)    return false;
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: pgsphere
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsphere