Re: auto_explain produces invalid JSON - Mailing list pgsql-hackers

From Tom Lane
Subject Re: auto_explain produces invalid JSON
Date
Msg-id 17663.1328991731@sss.pgh.pa.us
Whole thread Raw
In response to Re: auto_explain produces invalid JSON  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: auto_explain produces invalid JSON  (Andrew Dunstan <andrew@dunslane.net>)
Re: auto_explain produces invalid JSON  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> But ExplainBeginOutput says:

>       case EXPLAIN_FORMAT_JSON:
>            /* top-level structure is an array of plans */
>            appendStringInfoChar(es->str, '[');

> Now that's not true in the auto-explain case, which prints one query + 
> one plan.

What about queries that expand to multiple plans because of rules?

> Since this is an exposed API, I don't think we can just change it. We 
> probably need a new API that does the right thing for beginning and 
> ending auto_explain output. (ExplainBeginLabeledOutput?)

I'm inclined to think that this is auto_explain's error, not that of
the core code, ie we should be changing the output.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: auto_explain produces invalid JSON
Next
From: Andrew Dunstan
Date:
Subject: Re: auto_explain produces invalid JSON