The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hi Laurenz,
Nice focused patch.
Applied successfully on commit 62a17a92 from master.
Documentation is updated and there is an explanatory comment for the code, as well as a descriptive commit message.
To check the patch, I added the following test at the end of src/bin/scripts/t/100_vacuumdb.pl in both master (as
experiment)and your patch. In master it does not pass, but with your patch applied it does.
You can consider adding it to your patch, or I could also do that.
$node->safe_psql('postgres',
"CREATE TABLE parent_table (a INT) PARTITION BY LIST (a);\n"
. "CREATE TABLE child_table PARTITION OF parent_table FOR VALUES IN (1);\n"
. "INSERT INTO parent_table VALUES (1);\n");
$node->issues_sql_like(
[
'vacuumdb', '--analyze-only', 'postgres'
],
qr/statement:\s+ANALYZE\s+public\.parent_table/s,
'--analyze_only updates statistics for partitioned tables');
Kind regards,
Mircea Cadariu
The new status of this patch is: Waiting on Author
