Re: language cleanups in code and docs - Mailing list pgsql-hackers

From Jonathan S. Katz
Subject Re: language cleanups in code and docs
Date
Msg-id 172c908a-17f4-59e0-446f-a6f2e1217e14@postgresql.org
Whole thread Raw
In response to Re: language cleanups in code and docs  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On 6/17/20 6:32 AM, Magnus Hagander wrote:

> In looking at this I realize we also have exactly one thing referred to
> as "blacklist" in our codebase, which is the "enum blacklist" (and then
> a small internal variable in pgindent). AFAICT, it's not actually
> exposed to userspace anywhere, so we could probably make the attached
> change to blocklist at no "cost" (the only thing changed is the name of
> the hash table, and we definitely change things like that in normal
> releases with no specific thought on backwards compat).

+1. Though if we are doing that, we should also handle "whitelist" too,
as this attached patch does. It's mostly in comments (with one Perl
variable), but I switched the language around to use "allowed"

Jonathan

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Next
From: "Jonathan S. Katz"
Date:
Subject: Re: language cleanups in code and docs