Re: fix for windows breakage in regression script - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: fix for windows breakage in regression script
Date
Msg-id 1729.24.211.141.25.1105764886.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: fix for windows breakage in regression script  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: fix for windows breakage in regression script  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane said:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Tom Lane wrote:
>>> Hm --- have you checked it since I changed the script?
>
>> yes. See
>> http://www.pgbuildfarm.org/cgi-bin/show_history.pl?nm=gibbon&br=HEAD
>
> [ scratches head... ]  Why isn't the #undef in pg_config_manual.h
> firing on Cygwin?

The lines say:

#if defined(__QNX__) || defined(__BEOS__) || defined(WIN32)
#undef HAVE_UNIX_SOCKETS
#endif

But on Cygwin, WIN32 is only defined if windows.h has been included (See
previous discussion - I recall advocating NOT using WIN32 as a marker for
just this reason).


cheers

andrew



pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: fix for windows breakage in regression script
Next
From: Tom Lane
Date:
Subject: Re: fix for windows breakage in regression script