Re: [PATCH] Add roman support for to_number function - Mailing list pgsql-hackers

From Maciek Sakrejda
Subject Re: [PATCH] Add roman support for to_number function
Date
Msg-id 172573508957.1127.13514581275952642481.pgcf@coridan.postgresql.org
Whole thread Raw
Responses Re: [PATCH] Add roman support for to_number function
Re: [PATCH] Add roman support for to_number function
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, failed
Spec compliant:           tested, failed
Documentation:            tested, passed

Tested again, and the patch looks good. It does not accept leading or trailing whitespace, which seems reasonable,
giventhe unclear behavior of to_number with other format strings. It also rejects less common Roman spellings like
"IIII".I don't feel strongly about that one way or the other, but perhaps a test codifying that behavior would be
usefulto make it clear it's intentional.
 

I'm marking it RfC.

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Yet another way for pg_ctl stop to fail on Windows
Next
From: Maciek Sakrejda
Date:
Subject: Re: [PATCH] Add roman support for to_number function