Re: should we document an example to set multiple libraries in shared_preload_libraries? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: should we document an example to set multiple libraries in shared_preload_libraries?
Date
Msg-id 1721781.1638364504@sss.pgh.pa.us
Whole thread Raw
In response to Re: should we document an example to set multiple libraries in shared_preload_libraries?  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: should we document an example to set multiple libraries in shared_preload_libraries?  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Re: should we document an example to set multiple libraries in shared_preload_libraries?  (Maciek Sakrejda <m.sakrejda@gmail.com>)
List pgsql-hackers
Justin Pryzby <pryzby@telsasoft.com> writes:
> +1 to document it, but it seems like the worse problem is allowing the admin to
> write a configuration which causes the server to fail to start, without having
> issued a warning.

> I think you could fix that with a GUC check hook to emit a warning.
> I'm not sure what objections people might have to this.  Maybe it's confusing
> to execute preliminary verification of the library by calling stat() but not do
> stronger verification for other reasons the library might fail to load.  Like
> it doesn't have the right magic number, or it's built for the wrong server
> version.  Should factor out the logic from internal_load_library and check
> those too ?

Considering the vanishingly small number of actual complaints we've
seen about this, that sounds ridiculously over-engineered.
A documentation example should be sufficient.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: should we document an example to set multiple libraries in shared_preload_libraries?
Next
From: Amit Kapila
Date:
Subject: Re: Optionally automatically disable logical replication subscriptions on error