Re: Add Nullif case for eval_const_expressions_mutator - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Add Nullif case for eval_const_expressions_mutator
Date
Msg-id 170e5c7f-6f78-7aa6-1797-5e429e9b972d@enterprisedb.com
Whole thread Raw
In response to Re: Add Nullif case for eval_const_expressions_mutator  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On 30.03.21 11:20, Peter Eisentraut wrote:
> On 24.03.21 11:52, houzj.fnst@fujitsu.com wrote:
>>> +                if (!has_nonconst_input)
>>> +                    return ece_evaluate_expr(expr);
>>>
>>> That's not okay without a further check to see if the comparison 
>>> function used
>>> by the node is immutable.  Compare ScalarArrayOpExpr, for instance.
>>
>> Thanks for pointing it out.
>> Attaching new patch with this change.
> 
> This patch looks okay to me and addresses all the feedback that was 
> given.  If there are no more comments, I'll commit it in a few days.

done



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Fix pg_checksums progress report
Next
From:
Date:
Subject: RE: Fix pg_checksums progress report