Re: Add minimal C example and SQL registration example for custom table access methods. - Mailing list pgsql-hackers

From Roberto Mello
Subject Re: Add minimal C example and SQL registration example for custom table access methods.
Date
Msg-id 170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org
Whole thread Raw
Responses Re: Add minimal C example and SQL registration example for custom table access methods.  (Tristen Raab <tristen.raab@highgo.ca>)
Re: Add minimal C example and SQL registration example for custom table access methods.  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
List pgsql-hackers
Suggestion:

In the C example you added you mention in the comment:

+  /* Methods from TableAmRoutine omitted from example, but all
+     non-optional ones must be provided here. */

Perhaps you could provide a "see <xyz>" to point the reader finding your example where he could find these non-optional
methodshe must provide?
 

Nitpicking a little: your patch appears to change more lines than it does, because it added line breaks earlier in the
lines.I would generally avoid that unless there's good reason to do so. 

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: lazy_scan_heap() should release lock on buffer before vacuuming FSM
Next
From: jian he
Date:
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)