Hello!
+/*
+ * In case of parallel workers, the last time the delay has been reported to
+ * the leader.
+ * We assume this initializes to zero.
+ */
+static instr_time last_report_time;
Maybe last_report_time would be better named worker_last_report_time? (It is not clear to me from the comment that the
variableis not used by the leader or autovacuum worker at all)
+ /* Parallel worker */
+ if (IsParallelWorker())
I think this comment doesn't add value (just repeats the code), maybe delete it?
I was surprised that the patch does not add reporting for log_autovacuum_min_duration. But I see it was discussed
earlier,great. (postponed for another topic&patch)
- code looks good
- docs pass (not a native English speaker)
- check-world pass
regards, Sergei
