Re: Remove useless casts to (void *) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove useless casts to (void *)
Date
Msg-id 1688835.1733179353@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove useless casts to (void *)  (Andres Freund <andres@anarazel.de>)
Responses Re: Remove useless casts to (void *)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2024-12-02 17:11:30 -0500, Tom Lane wrote:
>> I'm inclined to propose adding something like
>> CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
>> to src/template/solaris.  Not sure if we have a corresponding
>> mechanism for meson, though.

> elif host_system == 'sunos'
>   portname = 'solaris'
>   export_fmt = '-Wl,-M@0@'
>   cppflags += '-D_POSIX_PTHREAD_SEMANTICS'

> Should be trivial to add there.

Oh!  The corresponding bit in configure.ac is

# On Solaris, we need this #define to get POSIX-conforming versions
# of many interfaces (sigwait, getpwuid_r, ...).
if test "$PORTNAME" = "solaris"; then
  CPPFLAGS="$CPPFLAGS -D_POSIX_PTHREAD_SEMANTICS"
fi

Barely even need to adjust the comment ;-).  I'll proceed with
improving that (in master only, don't think we need it in back
branches, at least not today) unless somebody pushes back soon.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [18] Unintentional behavior change in commit e9931bfb75
Next
From: Andres Freund
Date:
Subject: Re: Remove useless casts to (void *)