Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update
Date
Msg-id 16887.1386260153@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Avoid resetting Xmax when it's a multi with an aborted update  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Avoid resetting Xmax when it's a multi with an aborted update

I may be confused, but this patch doesn't look like it does what
your commit log message says.  It looks to me like the logic for
setting the hint bit is exactly the same as before; what's changed
is only the return code from HeapTupleSatisfiesUpdate.

The code looks right, though.  Is it just that your commit message
misdescribes it?

            regards, tom lane


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Avoid resetting Xmax when it's a multi with an aborted update
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update