Re: Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()
Date
Msg-id 16807.1275925518@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes:
> This commit changed walsender so that it doesn't call set_ps_display() if
> update_process_title = off.

Yeah.  The idea is to not waste time on a useless snprintf() call when the
GUC is turned off.

> On the other hand, walreceiver doesn't check
> update_process_title. Though this check might not be required since it's
> within set_ps_display(), we should do that for the sake of consistency?

Seems reasonable to make the same minor optimization on that side.
Will commit.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: SR slaves and .pgpass
Next
From: Dave Cramer
Date:
Subject: pgstatindex still throws ERROR: value "3220078592" is out of range for type integer