Protection lost in expression eval changeover - Mailing list pgsql-hackers

From Tom Lane
Subject Protection lost in expression eval changeover
Date
Msg-id 16803.1490723570@sss.pgh.pa.us
Whole thread Raw
Responses Re: Protection lost in expression eval changeover  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
CheckVarSlotCompatibility contains the comment
 * Note: we allow a reference to a dropped attribute.  slot_getattr will * force a NULL result in such cases.

While still true, that second sentence is now quite irrelevant, because we
don't go through slot_getattr anymore.  So it seems like we are missing
some needed protection.  I'm inclined to think that it'd be all right to
just throw an error immediately in CheckVarSlotCompatibility if the
target column is dropped.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: Monitoring roles patch
Next
From: David Steele
Date:
Subject: Re: Supporting huge pages on Windows