Re: [PATCH] expand the units that pg_size_pretty supports on output - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] expand the units that pg_size_pretty supports on output
Date
Msg-id 1677540.1625583283@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] expand the units that pg_size_pretty supports on output  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: [PATCH] expand the units that pg_size_pretty supports on output  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> Does anyone want to have a look over this?  If not, I plan to push it
> in the next day or so.

Minor nit: use "const char *text" in the struct declaration, so
that all of the static data can be placed in fixed storage.

> (I'm not sure why pgindent removed the space between != and NULL, but
> it did, so I left it.)

It did that because "text" is a typedef name, so it's a bit confused
about whether the statement is really a declaration.  Personally I'd
have used "name" or something like that for that field, anyway.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jeevan Ladhe
Date:
Subject: Re: .ready and .done files considered harmful
Next
From: Alvaro Herrera
Date:
Subject: Re: Pipeline mode and PQpipelineSync()