Re: create_unique_path and GEQO - Mailing list pgsql-hackers

From Tom Lane
Subject Re: create_unique_path and GEQO
Date
Msg-id 16756.1490363418@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] create_unique_path and GEQO  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Responses Re: [HACKERS] create_unique_path and GEQO  (Michael Paquier <michael.paquier@gmail.com>)
Re: [HACKERS] create_unique_path and GEQO  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> writes:
>> Do you have test case, which can reproduce the issue you
>> explained above?

> No. It would require some surgery in standard_planner() to measure the
> memory consumed in the planner context OR build the code with
> SHOW_MEMORY_STATS defined and dump memory context statistics and check
> planner context memory usage. I don't think I can produce a testcase
> quickly right now. But then, I think the problem is quite apparent
> from the code inspection alone, esp. comparing what mark_dummy_rel()
> does with what create_unique_path() is doing.

Yeah.  I think the code in mark_dummy_rel is newer and better-thought-out
than what's in create_unique_path.  It probably makes sense to change over.
        regards, tom lane



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: increasing the default WAL segment size
Next
From: Peter Eisentraut
Date:
Subject: Re: Logical replication existing data copy