Re: Cast jsonb to numeric, int, float, bool - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Cast jsonb to numeric, int, float, bool
Date
Msg-id 16735.1525808495@sss.pgh.pa.us
Whole thread Raw
In response to Re: Cast jsonb to numeric, int, float, bool  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Teodor Sigaev <teodor@sigaev.ru> writes:
> Thanks for your idea, patch is attached

Looks mostly fine from here.  A couple nitpicks:

* s/translable/translatable/

* Personally I'd try harder to make the lookup table constant, that is

+    static const struct
+    {
+        enum jbvType    type;
+        const char    *msg;
+    }
+        messages[] =
+    {

in hopes that it'd end up in the text segment.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Next
From: Peter Eisentraut
Date:
Subject: Re: perlcritic script