Re: transformExpr() refactor - Mailing list pgsql-patches

From Tom Lane
Subject Re: transformExpr() refactor
Date
Msg-id 1673.1098973071@sss.pgh.pa.us
Whole thread Raw
In response to transformExpr() refactor  (Neil Conway <neilc@samurai.com>)
Responses Re: transformExpr() refactor  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> This patch refactors transformExpr(): rather than being a monsterous 900
> line function, it breaks it up into numerous sub-functions that are
> invoked by transformExpr() for individual expression types, in the style
> of transformStmt().

I don't actually find this to be an improvement.  What's the point?
Since all the switch arms are independent, you haven't really done
anything at all to improve the comprehensibility of the code...

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Updated Turkish translation: postgres
Next
From: Andrew Dunstan
Date:
Subject: rmtree cleanup