Re: Arbitary file size limit in twophase.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Arbitary file size limit in twophase.c
Date
Msg-id 16728.1210947988@sss.pgh.pa.us
Whole thread Raw
In response to Re: Arbitary file size limit in twophase.c  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
Responses Re: Arbitary file size limit in twophase.c  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-hackers
"Heikki Linnakangas" <heikki@enterprisedb.com> writes:
> Tom Lane wrote:
>> It might be worth checking at prepare that the file size doesn't exceed
>> MaxAllocSize, but any smaller limit strikes me as (a) unnecessarily
>> restrictive and (b) not actually creating any useful guarantee.

> Patch attached. I can't commit it myself right now, but will do so as 
> soon as I can, unless there's objections.

Two bugs: "exceeed" -> "exceeded", please; and on the read side, you
should still have an upper-bound check, but it should be MaxAllocSize.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: deadlock while doing VACUUM and DROP
Next
From: Tom Lane
Date:
Subject: Re: deadlock while doing VACUUM and DROP