Re: postgres_fdw: using TABLESAMPLE to collect remote sample - Mailing list pgsql-hackers

From James Finnerty
Subject Re: postgres_fdw: using TABLESAMPLE to collect remote sample
Date
Msg-id 167112207543.1120.12195641719862911275.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: postgres_fdw: using TABLESAMPLE to collect remote sample  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: postgres_fdw: using TABLESAMPLE to collect remote sample
List pgsql-hackers
This patch looks good to me.  I have two very minor nits: The inflation of the sample size by 10% is arbitrary but it
doesn'tseem unreasonable or concerning.  It just makes me curious if there are any known cases that motivated adding
thislogic.  Secondly, if the earliest non-deprecated version of PostgreSQL supports sampling, then you could optionally
removethe logic that tests for that. The affected lines should be unreachable. 

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Support logical replication of DDLs
Next
From: Tom Lane
Date:
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample