Re: [PATCH] Allow specification of custom slot for custom nodes - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: [PATCH] Allow specification of custom slot for custom nodes
Date
Msg-id 166903761072.1121.2757138082242561269.pgcf@coridan.postgresql.org
Whole thread Raw
In response to [PATCH] Allow specification of custom slot for custom nodes  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: [PATCH] Allow specification of custom slot for custom nodes
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionality
unlessanyone (e.g. extension) sets its own slotOps in CustomScanState.
 
Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing
extensibility.So I think adding more extensibility regarding different tuple formats is an excellent thing to do.
 

I'm going to mark it as RfC if there are no objections.

Kind regards,
Pavel Borisov, 
Supabase

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Split index and table statistics into different types of stats
Next
From: Simon Riggs
Date:
Subject: Re: Allow single table VACUUM in transaction block