Re: Add PortalDrop in exec_execute_message - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add PortalDrop in exec_execute_message
Date
Msg-id 1664095.1622063992@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add PortalDrop in exec_execute_message  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Add PortalDrop in exec_execute_message
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> (I didn't add a Close Portal message to PQsendQueryInternal in pipeline
> mode precisely because there is no such message in PQsendQueryGuts.
> I think it would be wrong to unconditionally add a Close Portal message
> to any of those places.)

Yeah, I'm not very comfortable with having libpq take it on itself
to do that, either.

Looking back at the original complaint, it seems like it'd be fair to
wonder why we're still holding a page pin in a supposedly completed
executor run.  Maybe the right fix is somewhere in the executor
scan logic.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: storing an explicit nonce
Next
From: Greg Sabino Mullane
Date:
Subject: Speed up pg_checksums in cases where checksum already set